Fix deadlock in data-channels-flow-control example. #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainliu
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #101 I realized that a deadlock is occurring when using data-channels-flow-control example. This has something to do with the requestor and responder using the same
tokioevent loop. When I split the data-channels-flow-control into two processes (like in the e.g. offer-answer) the deadlock did not show up. After more investigation it seems to deadlock occurs after the write_loop is woken up andassociation_internal.lock()is waited on. Yielding before acquiring the lock allows other tasks to make progress which seems to prevent the writer from blocking. I tested it on x86_64 and Darwin.