Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fix emulation error of lstm by 'backward' and 'both' direction options #802

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Bugfix: Fix emulation error of lstm by 'backward' and 'both' direction options #802

merged 2 commits into from
Jan 22, 2025

Conversation

BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Jan 14, 2025 •
edited by pr-preview bot
Loading

This PR is to fix lstm emulation error of #801.
@fdwr @huningxin PTAL, thanks!

Preview | Diff

fdwr
fdwr approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 TY Bruce.

huningxin
huningxin approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments about format.

/cc @philloooo

huningxin
huningxin approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fdwr fdwr mentioned this pull request Jan 22, 2025
Closed
@BruceDai
Copy link
Contributor Author

@philloooo Gentle ping, PTAL, thanks!

@philloooo
Copy link
Contributor

LGTM

@fdwr fdwr merged commit 293d074 into webmachinelearning:main Jan 22, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 22, 2025
@BruceDai @github-actions
Bugfix: Fix emulation error of lstm by 'backward' and 'both' directio…
c37ca4a 
…n options (#802)

SHA: 293d074
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BruceDai @philloooo @huningxin @fdwr