Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MLOperandDescriptor.shape required #764

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

a-sully
Copy link
Contributor

@a-sully a-sully commented Sep 24, 2024

Fixes #758


Preview | Diff

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit 81a355a into webmachinelearning:main Sep 25, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Sep 25, 2024
SHA: 81a355a
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@a-sully a-sully deleted the require-shape branch September 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make MLOperandDescriptor.shape a required dictionary member
3 participants