Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add int64/uint64 to ArrayBufferView compatibility table #698

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented May 30, 2024

Fixes #693


Preview | Diff

@inexorabletash inexorabletash requested review from huningxin and fdwr May 30, 2024 21:11
@inexorabletash
Copy link
Member Author

Seems straightforward? @huningxin & @fdwr - please take a look?

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit 932b603 into webmachinelearning:main Jun 1, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jun 1, 2024
SHA: 932b603
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the int64-op-buffer-table branch June 1, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLOperandDataType and ArrayBufferView compatibility table missing int64/uint64
3 participants