Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NPU device type and three fp16 models for image classification #226

Merged
merged 6 commits into from
May 7, 2024
Merged

Add NPU device type and three fp16 models for image classification #226

merged 6 commits into from
May 7, 2024

Conversation

mingmingtasd
Copy link
Contributor

PTAL, thanks! @Honry @huningxin @ibelem

@huningxin
Copy link
Contributor

I think we can extend WebNN Installation Guides to help developers test WebNN on NPU. For example, through DirectML developer preview for NPU on new Intel® Core™ Ultra devices on Windows. We can extend the guide for other platforms later.

Honry
Honry reviewed Apr 30, 2024
View reviewed changes
image_classification/main.js Outdated Show resolved Hide resolved
image_classification/index.html Show resolved Hide resolved
Honry
Honry approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Honry
Copy link
Collaborator

Honry commented Apr 30, 2024

cc/ @JiangYueBook, this change would impact your automation tool.

@mingmingtasd
Copy link
Contributor Author

I think we can extend WebNN Installation Guides to help developers test WebNN on NPU. For example, through DirectML developer preview for NPU on new Intel® Core™ Ultra devices on Windows. We can extend the guide for other platforms later.

Yes, we should add, can I send another PR for it later? @huningxin

huningxin
huningxin reviewed May 5, 2024
View reviewed changes
common/utils.js Outdated Show resolved Hide resolved
image_classification/main.js Outdated Show resolved Hide resolved
@Honry Honry mentioned this pull request May 5, 2024
Merged
Honry
Honry reviewed May 7, 2024
View reviewed changes
image_classification/efficientnet_fp16_nchw.js Outdated Show resolved Hide resolved
image_classification/efficientnet_fp16_nchw.js Outdated Show resolved Hide resolved
image_classification/efficientnet_fp16_nchw.js Outdated Show resolved Hide resolved
image_classification/efficientnet_fp16_nchw.js Show resolved Hide resolved
image_classification/efficientnet_fp16_nchw.js Show resolved Hide resolved
image_classification/mobilenet_nchw.js Outdated Show resolved Hide resolved
image_classification/resnet50v1_fp16_nchw.js Outdated Show resolved Hide resolved
@mingmingtasd
Copy link
Contributor Author

PTAL, thanks! @Honry

Honry
Honry approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @huningxin, would you like to take another look?

huningxin
huningxin approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huningxin huningxin merged commit 480ab02 into webmachinelearning:master May 7, 2024
3 checks passed
This was referenced May 7, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huningxin huningxin huningxin approved these changes

@Honry Honry Honry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingmingtasd @huningxin @Honry