-
Notifications
You must be signed in to change notification settings - Fork 25
Add lending timeline #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lending timeline #3824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3824 +/- ##
=======================================
Coverage 90.02% 90.03%
=======================================
Files 752 753 +1
Lines 24246 24256 +10
=======================================
+ Hits 21828 21838 +10
Misses 2418 2418 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm not sure I agree with the status translation strings being defined in backend, but it's fine if that avoids unnecessary complexity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but what is the difference between unapproved now? Is it used at all?
The initial status is still unapproved, and administrators can still remove an approval. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪨🧨
Description
Adds a timeline to the lending detail page. The timeline contains system actions automatically generated by the backend as well as submitted comments on the request.
Frontend
Result
Screencast.From.2025-04-03.22-13-05.mp4
Testing
Create a new lending request and verify that a creation entry is present in the timeline. Verify that commenting on the request works and that submitting actions also creates timeline entries.
Resolves ABA-1398