Show error dialog on unhandled rejection and uncaught exception #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors aren't supposed to happen in the samples, but if they do, we want them to be visible. Otherwise they can only be seen in the dev tools console, and sometimes you can't tell that the sample is misbehaving, e.g.: webgpu#501 (comment)
beaufortfrancois
approved these changes
Apr 18, 2025
greggman
approved these changes
Apr 18, 2025
kainino0x
added a commit
to kainino0x/webgpu-samples
that referenced
this pull request
Apr 21, 2025
…on (webgpu#502)" (webgpu#509) Reland with fix. Reverted in webgpu#509. Original in webgpu#502.
kainino0x
added a commit
to kainino0x/webgpu-samples
that referenced
this pull request
Apr 21, 2025
…on (webgpu#502)" (webgpu#509) Reland with fix. Reverted in webgpu#509. Original in webgpu#502.
kainino0x
added a commit
to kainino0x/webgpu-samples
that referenced
this pull request
Apr 21, 2025
…on (webgpu#502)" (webgpu#509) Reland with fix. Reverted in webgpu#509. Original in webgpu#502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors aren't supposed to happen in the samples, but if they do, we want them to be visible. Otherwise they can only be seen in the dev tools console, and sometimes you can't tell that the sample is misbehaving, e.g.:
#501 (comment)