Skip to content

Fix the Cornell sample to run on desktop Compat. #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix the Cornell sample to run on desktop Compat. #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions sample/cornell/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,22 @@ import {

const canvas = document.querySelector('canvas') as HTMLCanvasElement;

const presentationFormat = navigator.gpu.getPreferredCanvasFormat();
const features: GPUFeatureName[] =
presentationFormat === 'bgra8unorm' ? ['bgra8unorm-storage'] : [];
const adapter = await navigator.gpu?.requestAdapter({
featureLevel: 'compatibility',
});
quitIfAdapterNotAvailable(adapter);

for (const feature of features) {
if (!adapter.features.has(feature)) {
throw new Error(
`sample requires ${feature}, but is not supported by the adapter`
);
const features: GPUFeatureName[] = [];
let presentationFormat = navigator.gpu.getPreferredCanvasFormat();
if (presentationFormat == 'bgra8unorm') {
if (adapter.features.has('bgra8unorm-storage')) {
features.push('bgra8unorm-storage');
} else {
// If the GPU prefers BGRA for presentation but the Adapter
// doesn't support bgra8unorm-storage (e.g., Compatibility
// mode), use rgba8unorm for both. This will be slower, but will
// work.
presentationFormat = 'rgba8unorm';
}
}
const limits: Record<string, GPUSize32> = {};
Expand Down