Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload simulator: update timestamp query API usage #484

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Workload simulator: update timestamp query API usage #484

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a3ff1
Updated API for timestamp queries
jdarpinian Jan 3, 2025
ed550ea
Remove timestamp-query support
jdarpinian Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions sample/workloadSimulator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ <h2><center>Web graphics workload simulator</center></h2>
}, 0, 2);
const useTimestampQueries = adapter.features.has('timestamp-query');
device = await adapter.requestDevice({
nonGuaranteedFeatures: useTimestampQueries ? ['timestamp-query'] : [],
requiredFeatures: useTimestampQueries ? ['timestamp-query'] : [],
});
device.addEventListener('uncapturederror', (e)=>{
if (!errorMessage.textContent) errorMessage.textContent = 'Uncaptured error: ' + e.error.message;
Expand Down Expand Up @@ -731,14 +731,16 @@ <h2><center>Web graphics workload simulator</center></h2>
}
try {
const canvasView = canvasContext.getCurrentTexture().createView();
const commandBuffers = [];
device.queue.writeBuffer(uniformBuffer, 0, new Float32Array([position[0] / size * 2 - 1, 1 - position[1] * 2 / size]));
let buffer = null;

// Start off by writing a timestamp for the beginning of the frame.
const timestampEncoder = device.createCommandEncoder();
if (querySet) timestampEncoder.writeTimestamp(querySet, 0);
device.queue.submit([timestampEncoder.finish()]);
if (querySet) {
const timestampEncoder = device.createCommandEncoder();
timestampEncoder.beginComputePass({ timestampWrites: { querySet, beginningOfPassWriteIndex: 0, } }).end();
device.queue.submit([timestampEncoder.finish()]);
}

device.queue.writeBuffer(uniformBuffer, 0, new Float32Array([position[0] / size * 2 - 1, 1 - position[1] * 2 / size]));
let buffer = null;

// Upload data using createBuffer with mappedAtCreation.
if (bufferData.value > 0) {
Expand Down Expand Up @@ -815,6 +817,7 @@ <h2><center>Web graphics workload simulator</center></h2>
clearValue: [1, 1, 1, 1],
storeOp: multisampling.checked ? 'discard' : 'store',
}, ],
timestampWrites: querySet ? { querySet, endOfPassWriteIndex: 1 } : undefined,
});
if (useRenderBundles.checked && renderBundle && instances == renderBundleInstances && renderBundleNumDrawCalls == numDrawCalls) {
// If we have valid RenderBundles to use, execute them and we're done.
Expand Down Expand Up @@ -892,8 +895,6 @@ <h2><center>Web graphics workload simulator</center></h2>
if (buffer) buffer.destroy();
let queryBuffer;
if (querySet) {
// Timestamp for the end of the frame.
commandEncoder.writeTimestamp(querySet, 1);
// We create a queue of staging buffers to hold the timestamps while we
// map them into CPU memory. If the queue is empty, create a new buffer.
if (queryBuffers.length == 0) {
Expand All @@ -908,8 +909,7 @@ <h2><center>Web graphics workload simulator</center></h2>
commandEncoder.resolveQuerySet(querySet, 0, 2, queryResolveBuffer, 0);
commandEncoder.copyBufferToBuffer(queryResolveBuffer, 0, queryBuffer, 0, 16);
}
commandBuffers.push(commandEncoder.finish());
device.queue.submit(commandBuffers);
device.queue.submit([commandEncoder.finish()]);
if (querySet) {
// Once the staging buffer is mapped we can finally calculate the frame duration
// and put the staging buffer back into the queue.
Expand Down