-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamp query example #472
Conversation
Thanks for the feedback! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split LGTM, just one comment!
Co-authored-by: Kai Ninomiya <[email protected]>
Thank you! |
As you can see in https://developer.chrome.com/blog/new-in-webgpu-121#timestamp_queries_in_compute_and_render_passes and https://webgpu.github.io/webgpu-samples/?sample=computeBoids, there was already a sample featuring timestamp-query. Note that since we moved to a white background iframe, the text on large desktop didn't show up properly. I'm fixing it with #477 |
The journey I followed is (a) "oh I need to quickly test a thing with timestamp queries" (b) "mmh I remember there is this nice sample repo where I can find examples, let's look for one about timestamps" (c) "arf, don't find an example whose name says "timestamp"... maybe in benchmark section? nope" (d) "okey then, let's write it then and share it back where I expected to find it". :) |
I apologize if my previous message came across as harsh. That was not my intention. I realize that I could have been clearer in the title by specifying that it involved timestamp queries. I take full responsibility for this oversight. |
No worry, really :) |
We have a little |
Add an example that issues a single draw call of a cube (taken from the
texturedCube
example) and measures its duration thanks to timestamp queries.