Skip to content

Fix blue trail #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix blue trail #469

merged 2 commits into from
Oct 28, 2024

Conversation

beaufortfrancois
Copy link
Collaborator

FIX #458

@beaufortfrancois beaufortfrancois mentioned this pull request Oct 22, 2024
Closed
mwyrzykowski
mwyrzykowski approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mwyrzykowski mwyrzykowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

kainino0x
kainino0x reviewed Oct 25, 2024
View reviewed changes
sample/particles/particle.wgsl Outdated
rand_seed = fract(rand_seed * cos(35.456+f32(invocation_id) * seed.yw));
rand_seed = fract(rand_seed * cos(41.235+f32(invocation_id) * seed.xw));
rand_seed = fract(rand_seed * cos(35.456+f32(invocation_id) * seed.yw * 0.01f));
rand_seed = fract(rand_seed * cos(41.235+f32(invocation_id) * seed.xw * 0.01f));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is probably only necessary because seed.x and seed.y can be large:

webgpu-samples/sample/particles/main.ts

Lines 416 to 419 in 1e3c2d3

Math.random() * 100,
Math.random() * 100, // seed.xy
1 + Math.random(),
1 + Math.random(), // seed.zw

Could we just adjust the seed instead so it's not so large? I'm not sure what effect it would have.

@beaufortfrancois
Copy link
Collaborator Author

I think I've found what cause this weird behavior. When adding brightnessFactor to UBO buffer in #432, I made a mistake. This PR fixes it.

@kainino0x
Copy link
Collaborator

Oh! Fantastic!

@kainino0x kainino0x merged commit 96b4556 into webgpu:main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

+1 more reviewer

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address Particles HDR sample blue trail

3 participants

@beaufortfrancois @kainino0x @mwyrzykowski