-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Occlusion Query Sample #431
Conversation
This is the simplest thing I could think of to demonstrate how to use Occlusion Queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this sample a lot! Than you for writing it!
1, -1, -1, 0, 0, -1, | ||
-1, -1, -1, 0, 0, -1, | ||
]); | ||
const indices = new Uint16Array([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could use something like Array(24).fill(0).map((e, i) => e + i);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that won't produce the correct indices. I think plain data is easier to follow for this. I reformatted the indices to be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks addressing nits!
This is the simplest thing I could think of to
demonstrate how to use Occlusion Queries.