a wireframe example #427
a wireframe example #427
Conversation
| return { | ||
| vertexBuffer, | ||
| indexBuffer, | ||
| indexFormat: 'uint32', |
There was a problem hiding this comment.
Why do we hardcode indexFormat there?
Shall it be part of models.ts returned data OR should it be defined const indexFormat = 'uint32'; like depthFormat below?
There was a problem hiding this comment.
it's there so different models can have different index formats. I get there aren't different formats here but I'd think I'd prefer to leave it as is, it shows a pattern
| layout: 'auto', | ||
| vertex: { | ||
| module: wireframeModule, | ||
| entryPoint: 'vsIndexedU32', |
There was a problem hiding this comment.
vsIndexedU32 is the only one used in wireframe.wgsl. Shall we consider removing vsUnindexed and vsIndexedU16 and omit entryPoint there when creating wireframePipeline?
There was a problem hiding this comment.
I removed them and just changed them to comments. This isn't production code tho, it's sample code and I think having alternative solutions people can look at is not a bad thing, even if they aren't used.
No description provided.