Use a simpler clearValue
#414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is obviously a personal preference but, ... I feel like
the `{ r: ?, g: ?, b: ?, a: ? }` format is left over from before
the time when an array of numbers was allowed?
The array of numbers is arguably more useful since all kinds of things
can easily provide an array of numbers. So, it seems like it would be good
for the samples to show the more useful usage. That way devs are not
mislead into thinking they need to take some array of numbers and
convert it into the more verbose format.
greggman
force-pushed
the
simpler-clearValue
branch
from
6ea25c3 to
6f48359
Compare
austinEng
approved these changes
Apr 3, 2024
kainino0x
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Personally I prefer using the [0,0,0,0] syntax always. I actually tried to remove the alternate syntax for everything other than colors before 1.0, but there wasn't appetite to do it. I'd probably have been happy to remove it for colors too, but it was not as easy of a sell because for BGRA formats it's still [r,g,b,a] and that's can be a tiny bit confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obviously a personal preference but, ... I feel like the
{ r: ?, g: ?, b: ?, a: ? }format is left over from before the time when an array of numbers was allowed?The array of numbers is arguably more useful since all kinds of things can easily provide an array of numbers. So, it seems like it would be good for the samples to show the more useful usage. That way devs are not mislead into thinking they need to take some array of numbers and convert it into the more verbose format.
wdyt?