Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to MSDF text antialiasing method by Paul Houx #405

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

rconde01
Copy link
Contributor

Probably the quality could still be improved but I think this is objectively better.

@greggman greggman requested a review from toji March 18, 2024 04:43
Copy link
Contributor

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a significant improvement, thanks! A few suggestions to keep the code style consistent, but otherwise LGTM!

For reference, here's a quick before and after shot:
Screenshot 2024-03-18 092310

And one that's zoomed in 4x so that you can better see the difference.
Screenshot 2024-03-18 092310-zoom

Looks quite a bit better in motion, too.

sample/textRenderingMsdf/msdfText.wgsl Outdated Show resolved Hide resolved
sample/textRenderingMsdf/msdfText.wgsl Outdated Show resolved Hide resolved
sample/textRenderingMsdf/msdfText.wgsl Outdated Show resolved Hide resolved
@toji toji merged commit 7830516 into webgpu:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants