Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back in scrolling source tabs #403

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

greggman
Copy link
Collaborator

I put < and > on the left and right. They should work on touch screens. Also made it so if you click a tab that is partially off screen it will get put on screen. Also if the url has a #<filename> it will start with that tab on screen.

Screen.Recording.2024-03-13.at.15.12.16.mov

@greggman greggman requested a review from toji March 14, 2024 00:47
@greggman
Copy link
Collaborator Author

#396

@greggman
Copy link
Collaborator Author

It's been driving me crazy but sometimes the scrollbar is under the tabs, and sometimes it's at the bottom but overlaid on top of the tabs. Compare this video to the one above

Screen.Recording.2024-03-13.at.21.28.25.mov

I don't know what's causing the difference. This video is from syncing to the repo on my home computer. It's also the reason I originally cancelled the PR this morning. It was working at home (scrollbar overlaid on tabs) but then at work they were under/below. I reset back to before I added iframes and they were under/below so made a few tweaks to make the side buttons align and put up the PR.

Now I get home, sync, and the scrollbars are back to overlaid. I wonder if it's a OS setting (i'll have to check at work tomorrow).

Screenshot 2024-03-13 at 21 34 12

In any case, it should be fine to approve I think. Unless you have any other issues you want addressed.

@greggman
Copy link
Collaborator Author

I occured to me a few minutes after the last comment that I could just set that setting on my home machine. I verified that's the difference. If I set "show scroll bars: always" then the bars appear under the tabs. If set to "automatically based on mouse or trackpad" then they are drawn overlaid on the tabs

Copy link
Contributor

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't know what could reasonably be done about the differing scroll bar behavior. I guess either the navigation buttons on either side of the tabs could be extended down to no longer leave a gap between them and the content or the scrollbar could be extended under the buttons, but it would have to do so in a way that while it encompassed them it didn't actually scroll them. Both sound unnecessarily tricky, and probably platform dependent.

In any case, I don't think that it's problematic as-is, we're really talking about a minor aesthetic quirk.

@greggman greggman merged commit 5123ecf into webgpu:main Mar 14, 2024
1 check passed
@greggman greggman deleted the scroll-tabs branch March 14, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants