Remove React guard from worker sample #391
Conversation
public/css/SampleLayout.css
Outdated
| @@ -13,7 +13,7 @@ | |||
| height: 100%; | |||
| border: none; | |||
| display: block; | |||
| background-color: #fff; | |||
| /*background-color: #fff;*/ | |||
| } | |||
There was a problem hiding this comment.
I don't think this should be removed. iframes (this seems like a bug in the spec to me) get their background color from their parent which is bad. The page itself might do have the default black text in which case you'd get black on black text. This is especially true for external samples. They all expect the default is white.
I think rather, add
:root {
color-scheme: light dark;
}to all the sample/**/index.html files? Let the samples be responsible for what background color they want.
Also, I think we should look into making the menus be responsive to dark/light prefs in some future PR.
wdyt?
There was a problem hiding this comment.
Agreed. I don't think the white backgrounds look great, but we can have the samples decide that for more consistency. I removed this change.
Removes some code from the worker sample that only existed to catch errors when the code was executed twice by React. Now that React has been removed it's no longer necessary.
Removes some code from the worker sample that only existed to catch errors when the code was executed twice by React. Now that React has been removed it's no longer necessary.
Also removed the white background style for sample iframes, which looked strange and I assume to be a mistake? If this was intentional let me know and I'll revert this bit.