Make the workload-simulator work as a sample #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if I should go through and fix this or not `npm run fix` fixes a bunch and leaves 5 unused vars. Also switch to type module (removes use-strict) and stop checking for 11yr old rAF
toji
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was specially hand coded. Now it can exist as a sample like other samples.
It wasn't clear to me if it should open in a iframe or pop out. I made it pop out since that is what it used to do.
Also, I could put a re-direct at the root if you think one is needed so links to the old one are still valid though I think people will figure it out without and it seems like clutter. wdyt?