Add Timestamp Queries to Bitonic Sort Example #347
Conversation
Test Merge
Merge main into my fork
Merge Main
Merge main into my fork.
Merge branches
src/sample/bitonicSort/main.ts
Outdated
| let querySet: GPUQuerySet; | ||
| let timestampQueryResolveBuffer: GPUBuffer; | ||
| let timestampQueryResultBuffer: GPUBuffer; | ||
| console.log(timestampQueryAvailable); |
There was a problem hiding this comment.
| console.log(timestampQueryAvailable); |
prefer not to log things automatically
src/sample/bitonicSort/main.ts
Outdated
| // MISCELLANEOUS SETTINGS | ||
| 'Display Mode': 'Elements', | ||
| // An atomic value representing the total number of swap operations executed over the course of the bitonic sort. | ||
| 'Total Swaps': 0, | ||
| // Time taken to sort in seconds (not nanoseconds!). If timestep query feature is not available then this will remain 0. | ||
| 'Sort Time': '0s', |
There was a problem hiding this comment.
why not display it in.. milliseconds? right now the seconds are hard to read. For me it sometimes says things like "0.000065536s"
It's probably not clear from the provided code yet, but the displayed time is accumulating the times of each step rather than displaying the time a single step takes to execute. Given that the last step is almost certainly swapping over global indices rather than workgroup local indices at greater than 512 elements, it stands to reason that the last step would take longer than the first step, but I don't believe there should be such a large disparity in time. Perhaps there should be a display controller that displays the time a single step takes to execute (i.e if you're using Execute Sort Step rather than Auto Sort), a display controller that accumulates the times for each step within a sort, and maybe a final display controller that averages out the time a sort takes under a certain sort config combination (Elements + Workgroup Size Limit) |
|
I think I'll fix/add that (maybe move this back to draft or ask for re-review later). |
… sort time for a full bitonic sort given the current configuration of Total Elements and Size Limit
@austinEng This should be finished now bar any unexpected bugs. |
Utilized example code found at https://developer.chrome.com/blog/new-in-webgpu-121 to add timestamp queries for the bitonic sort on compatible browsers.
At large enough element sizes, these queries can be used to compare the performance between sorts of various sizes, or compare performance when the maximum invocations per dispatch are arbitrarily limited.
Minor changes:
'Complete Sort' has been renamed to 'Auto Sort' to better reflect controller functionality.