New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize vector in fragment shader #332

Merged

shrekshao merged 1 commit into webgpu:main from tyfkda:feature/normalize-normal

Nov 27, 2023

Contributor

tyfkda commented Nov 24, 2023 •

edited

Loading

The normal vector passed to the fragment shader is the interpolated value between the vertex normals,
and it should be normalized.

In the deferredRendering sample, the normal vector is written to the G-buffer and used in a later pass.
It looks like the texture sampled value are being used directly:
https://github.com/webgpu/webgpu-samples/blob/2d193cb2764c736f435ce748630fae5f29f7518d/src/sample/deferredRendering/fragmentDeferredRendering.wgsl#L55C7-L59


          Normalize vector in fragment shader

63c0d54

austinEng requested a review from shrekshao

November 27, 2023 17:36

shrekshao approved these changes

View reviewed changes

shrekshao merged commit 78b9cc1 into webgpu:main

1 check passed

tyfkda deleted the feature/normalize-normal branch

November 28, 2023 00:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet