Fix confusing code in deferredRendering #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekshao
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
LGTM. Thanks for the change. I have no idea why the original code looks like that. Probably leftover when migrating from gl-matrix to wgpu-matrix
One comment: Remove eyePosition at line 479 as indicated by GithubActions
(I cannot add a comment there as github says "Line must be part of the diff")
* The initialization of `viewMatrix` incorrectly uses `mat4.inverse` with `mat4.lookAt`. * The `getCameraViewProjMatrix` function has a local variable of the same name, so it's not used. * `rotation` matrix is applied twice within the `getCameraViewProjMatrix` function. * Change `viewProjMatrix` to not reserve space in advance for the result matrix, similar to other matrices like `rotation` that don't do this. * Remove duplicated `eyePosition` definition.
|
@shrekshao Thank you for your review. |
|
@shrekshao, @austinEng, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the Deferred Rendering implementation due to some confusing code:
viewMatrixincorrectly usesmat4.inversewithmat4.lookAt.getCameraViewProjMatrixfunction has a local variable of the same name, so it's not used.rotationmatrix is applied twice within thegetCameraViewProjMatrixfunction.viewProjMatrixto not reserve space in advance for the result matrix, similar to other matrices likerotationthat don't do this.