Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tab Animation to Code Source Hover/Data-Active=True #322

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Nov 9, 2023

Cornell.box.-.WebGPU.Samples.-.Google.Chrome.2023-11-08.17-02-35.mp4

The animation does use the CSS :has property, but all devices that support WebGPU should be able to access that property. The readability of each CodeMirror tab is not affected when the window size is cramped.

@cmhhelgeson
Copy link
Contributor Author

Cornell.box.-.WebGPU.Samples.-.Google.Chrome.2023-12-04.13-50-17.mp4

Adding more representative video of switching between tabs.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice little bit of polish, LGTM!

@kainino0x kainino0x merged commit 21b1a14 into webgpu:main Dec 4, 2023
1 check passed
@cmhhelgeson cmhhelgeson deleted the folder_css_update branch December 4, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants