Flipped toybox normal map along x and y-axis. #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Merge
Merge main into my fork
Merge Main
|
It looks like after you flipped the height map, you then regenerated the normal-map, instead of just flipping that. For some reason, the normals for this texture then point the wrong way. I don't know why this texture appears wrong, when the others look okay. I wanted to confirm that this was an issue with the texture and not a bug in the code, so I spent some time going through the sample's code. I think the code was sound, but I cleaned up the code as I went along. PR (with the texture fix) here: #320 |
|
Pull request closed due to issues being more comprehensively addressed by #320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #317