Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workers can log to the console just fine. #311

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Workers can log to the console just fine. #311

merged 1 commit into from
Oct 29, 2023

Conversation

greggman
Copy link
Collaborator

Did you mean to say something else?

@greggman
Workers can log to the console just fine.
49368c2 
Did you mean to say something else?
@greggman greggman requested a review from toji October 28, 2023 23:15
toji
toji approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I legitimately thought that you still couldn't log from a worker. It was definitely a restriction at some point, but I'm glad to see that it works at this point. Thank you for catching my use of an outdated workaround!

@greggman greggman merged commit f757c7c into webgpu:main Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greggman @toji