Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image loading in normalMap sample #310

Merged
merged 23 commits into from
Oct 29, 2023

Conversation

cmhhelgeson
Copy link
Contributor

Get the image loading in the normalMap sample to actually work.

@cmhhelgeson
Copy link
Contributor Author

Got rid of any utils outside of the main function that handled loading images. I also put all the images back in the assets folder. For some reason, the .next folder and out folder only build in the assets as part of the website when the images are referenced in main? Not sure why that might be. Regardless, image loading should be fixed after this next commit.

@cmhhelgeson cmhhelgeson marked this pull request as ready for review October 27, 2023 19:39
@cmhhelgeson
Copy link
Contributor Author

This should probably be addressed as soon as possible, the current example on the website is nonfunctional.

next.config.js Outdated Show resolved Hide resolved
src/sample/normalMap/main.ts Outdated Show resolved Hide resolved
@@ -110,6 +110,11 @@ const init: SampleInit = async ({ canvas, pageState }) => {
// Fetch the image and upload it into a GPUTexture.
let cubeTexture: GPUTexture;
{
const url = new URL(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this changed? revert?

@greggman greggman merged commit f2eaf77 into webgpu:main Oct 29, 2023
1 check passed
@cmhhelgeson cmhhelgeson deleted the normal_map_branch branch April 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants