Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitonic Sort Update #309

Merged
merged 11 commits into from
Oct 31, 2023
Merged

Bitonic Sort Update #309

merged 11 commits into from
Oct 31, 2023

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Oct 27, 2023

An update to the bitonic sort example with a few new features: (UPDATED 10/30/2023)

  1. Initial sort automatically executes after page load and the speed of the sort can be dynamically adjusted.

  2. Will be to use multiple workgroups to sort more elements than the max number of threads per workgroup will allow. The program will also display, based on the number of elements, how many workgroups are dispatched per step, and the number of workgroups will dynamically update depending on the number of elements.

  3. Added an atomic counter that tracks the number of swaps that have been made during a sort.

  4. Various naming and GUI tweaks to decrease clutter and increase clarity including:
    a. GUI elements are now named controllers rather than cells to both match with Dat.GUI's types and to decrease confusion when referring to grid display cells.
    b. GUI elements that should be non-interactive have been made non-interactive
    c. GUI elements related to the changes above have been added

Pull request is not yet ready to review (UPDATE 10/30/2023 Ready for review)

@greggman greggman self-requested a review October 27, 2023 08:25
Copy link
Collaborator

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'm not super enthralled with the hacking the GUI but I'll work on providing a better solution and let this go for now.

@cmhhelgeson cmhhelgeson marked this pull request as ready for review October 30, 2023 01:36
@cmhhelgeson
Copy link
Contributor Author

Note: Changes were approved 3 days ago, but additional changes have come in that have yet to be reviewed.

…mic account of number of swaps performed during a sort
@cmhhelgeson
Copy link
Contributor Author

cmhhelgeson commented Oct 31, 2023

Made one more minor update that just removes interactivity from GUI elements and adds an atomic counter for the number of swaps made during a sort (ie the number of times idx.x > idx.y).

Definitely the last thing I'm adding, and in testing it seems to work fine, so it's ready for review.

@cmhhelgeson cmhhelgeson requested a review from greggman October 31, 2023 02:00
@greggman greggman merged commit b77d32c into webgpu:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants