ChartRedraw Fix #152 #153
ChartRedraw Fix #152 #153
Conversation
- Replaced `List.of()` with `Arrays.asList(new Object[])` to allow mixed-type arguments (e.g., String and Integer) in chart data rows. - Updated header and dynamic row addition logic to ensure compatibility with mixed data types. This fix resolves issue #152 related to `List.of()` incompatibility with heterogeneous data types.
There was a problem hiding this comment.
@laurenic0l This is not the appropriate way to resolve this issue. Please refactor the code to specify the columns and data arrays, similar to what you did in ChartView.java.
|
@jturfanbasis ready for review |
|
@jturfanbasis Thanks for catching that, I realized I didn't push the css file. Let me know if anything else! |
There was a problem hiding this comment.
@laurenic0l, can you please wrap the inputs in a flex container and make that them wrap for smaller screens.
|
|
@hyyan done! |
There was a problem hiding this comment.
When the user resizes the browser window, there is still no scroll bar.
You can find related bug report. #145
The application limits values to 2,147,483,647, which is the maximum for a 32-bit integer. However, when a user enters a value exceeding this limit, the application does not display a user-friendly error message. This should be improved to inform users why their input is invalid in a clear and understandable way.
Hey @jturfanbasis, please keep in mind that these are just demos. Our main goal is to introduce code that runs without any exceptions and should be as simple as possible to demonstrate the sample’s purpose. Validations should be added when they make sense, but guarding against edge cases is off-topic and outside the scope of these demos. Please don’t hesitate to report any details, and we’ll assess them case by case. We really appreciate your effort! |
Thank you Hyyan! |
List.of()withArrays.asList(new Object[])to allow mixed-type arguments (e.g., String and Integer) in chart data rows.This fix resolves issue #152 related to
List.of()incompatibility with heterogeneous data types.