Skip to content

Add max scroll limit in screenshot function to prevent timeout for infinite scroll page #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aman-Codes opened this issue Nov 16, 2022 · 2 comments · May be fixed by #9
Open

Add max scroll limit in screenshot function to prevent timeout for infinite scroll page #7

Aman-Codes opened this issue Nov 16, 2022 · 2 comments · May be fixed by #9
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Aman-Codes
Copy link
Member

Description

Currently the screenshot function will scroll the page by 200 units until it reaches the end of the page and then it takes a screenshot of that page. But for webpages with infinite scroll (like Google images page), it would give API timeout error. Hence a reasonable limit should be added on the number of times page is scrolled and also user should be able to specify that as a parameter in the post request. If no parameter is specified then a default value could be used.

Relevant Files

@Aman-Codes Aman-Codes added enhancement New feature or request good first issue Good for newcomers labels Nov 16, 2022
@Atish03
Copy link

Atish03 commented Nov 16, 2022

Can I work on it ?
And what would be an appropriate distance to scroll in such cases ?

@Aman-Codes
Copy link
Member Author

Sure @Atish03 go ahead.
Maybe scrolling atmax 10 times would be good for a default value.

@Atish03 Atish03 linked a pull request Nov 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants