Skip to content

Reduce puppeteer api response time #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Aman-Codes opened this issue Oct 22, 2022 · 2 comments
Open

Reduce puppeteer api response time #4

Aman-Codes opened this issue Oct 22, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Aman-Codes
Copy link
Member

Description

Puppeteer api sometimes takes too long(20-30s) to give the response. Need to reduce the api response time.
@Aman-Codes Aman-Codes added the help wanted Extra attention is needed label Oct 28, 2022
@Atish03
Copy link

Atish03 commented Nov 16, 2022

Does the screenshot of the page have to be of certain maximum value. For example in Reddit there is infinite scroll so the API scrolls for 300 seconds, Do we need that huge screenshot or some lesser time would do ?

@Aman-Codes
Copy link
Member Author

Aman-Codes commented Nov 16, 2022 •
edited
Loading

Hi @Atish03 Currently in case of web pages with infinite scroll the API would give a timeout error. So it would be good to have a reasonable limit on scroll. Created #7 to support screenshots for pages with infinite scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aman-Codes @Atish03