Skip to content

refactor(test): remove unnecessary assertion #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor(test): remove unnecessary assertion #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vscode-wdio-server/tests/worker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ describe('WdioExtensionWorker', () => {
exitCode: null,
killed: false,
}
vi.mocked(childProcess.spawn).mockReturnValue(mockChildProcess as any)
vi.mocked(childProcess.spawn).mockReturnValue(mockChildProcess)

// Setup HTTP server mock
mockServer = {
listen: vi.fn().mockReturnThis(),
unref: vi.fn(),
close: vi.fn().mockImplementation((cb) => cb && cb(null)),
}
vi.mocked(http.createServer).mockReturnValue(mockServer as any)
vi.mocked(http.createServer).mockReturnValue(mockServer)

// Setup WebSocketServer mock
mockWs = new EventEmitter()
Expand Down
4 changes: 2 additions & 2 deletions packages/vscode-wdio-test/tests/reporter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe('TestReporter', () => {
it('should return true when all tests passed', () => {
// Setup
const specPath = '/path/to/spec.js'
const specTestItem = createMockTestItem(specPath, 'spec.js') as vscode.TestItem
const specTestItem = createMockTestItem(specPath, 'spec.js')
const mockSuite = createMockTestSuite('Test Suite')
const mockResult = createMockResultSet([specPath], [mockSuite], { passed: 2, failed: 0, skipped: 0 })

Expand All @@ -138,7 +138,7 @@ describe('TestReporter', () => {
it('should return false when any test failed', () => {
// Setup
const specPath = '/path/to/spec.js'
const specTestItem = createMockTestItem(specPath, 'spec.js') as vscode.TestItem
const specTestItem = createMockTestItem(specPath, 'spec.js')
const mockSuite = createMockTestSuite('Test Suite')
const mockResult = createMockResultSet([specPath], [mockSuite], { passed: 1, failed: 1, skipped: 0 })

Expand Down
Loading