Skip to content

fix(expect-webdriverio): fix types for the toHaveValue and toHaveElementProperty matchers #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(expect-webdriverio): fix types for the toHaveValue and toHaveElementProperty matchers #1764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/matchers/element/toHaveElementProperty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ async function condition(
return compareText(prop, value as string | RegExp | ExpectWebdriverIO.PartialMatcher, options)
}

export async function toHaveElementProperty(
export async function toHaveElementProperty<T>(
received: WdioElementMaybePromise,
property: string,
value?: string | RegExp | ExpectWebdriverIO.PartialMatcher,
value?: T,
options: ExpectWebdriverIO.StringOptions = DEFAULT_OPTIONS
) {
const isNot = this.isNot
Expand Down
4 changes: 2 additions & 2 deletions src/matchers/element/toHaveValue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { toHaveElementProperty } from './toHaveElementProperty.js'
import { DEFAULT_OPTIONS } from '../../constants.js'
import type { WdioElementMaybePromise } from '../../types.js'

export function toHaveValue(
export function toHaveValue<T>(
el: WdioElementMaybePromise,
value: string | RegExp | ExpectWebdriverIO.PartialMatcher,
value: T,
options: ExpectWebdriverIO.StringOptions = DEFAULT_OPTIONS
) {
return toHaveElementProperty.call(this, el, 'value', value, options)
Expand Down