Repository navigation
Test the trace reader against real zips from an older writer - #515
Merged
Merged
Conversation
This was referenced Oct 30, 2026
The hosted player always runs the newest reader, while people open zips whatever adapter version recorded. Four real traces, one per adapter, from the writer as it was before the screenshot dedupe, are committed with a manifest counted from their raw entries, and a test checks the current reader still yields what each held. Real zips are mostly screenshots, so a committed script reduces each one: images become 1x1 images of the same format carrying their own resource name, and every other entry keeps its bytes. The reader never decodes an image, so nothing it can get wrong is lost; the set is 164 KB against 1.6 MB. Refs #510 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vishnuv688
force-pushed
the
perf/497-parse-in-worker
branch
from
October 30, 2026 10:12
6bfa403 to
938e36a
Compare
vishnuv688
force-pushed
the
test/510-trace-format-fixtures
branch
from
October 30, 2026 10:12
85c12cd to
857f076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Part of #510 and #494. Stacked on #514.
The hosted player always runs the newest reader, while people open zips written by whatever adapter version recorded them. This commits four real trace zips, one per adapter, from the writer as it was before #508, with a test that the current reader still yields what each one held. A reader change that breaks an older trace now fails
pnpm test.Type of change
Packages touched
shared(types and contracts)core(framework-agnostic capture/reporting)elements(published element/snapshot API —@wdio/elements)service(WebdriverIO adapter)nightwatch-devtools(Nightwatch adapter)selenium-devtools(Selenium adapter)selenium-devtools-py(Selenium Python adapter)backend(server)app(UI)script(page-injected runtime)trace(Trace mode)Capability matrix
packages/conformance/src/features.tsupdated, and tables regenerated withpnpm docs:capabilities, if this adds or changes user-facing behaviourNot needed: tests only.
Notes for reviewers
Fixtures
wdio-mocha-2026-10-28-14977b93selenium-mocha-2026-10-28-14977b93node:assert, JPEG screencast frames beside PNG onesnightwatch-bdd-2026-10-28-14977b93waitForElementVisiblerows, a failed native assertpython-pytest-2026-10-28-14977b93From the
examples-smokeartifact of CI run 40774299701 (commit14977b93, 2026-10-28). The two earlier artifacts available wrote the same format, so they add nothing a reader could break separately. The whole fixture directory is 164 KB.Reduction
reduce-fixture.ts, committed beside the fixtures so the next one is made the same way, keeps every entry, in order and under its name, and changes only images. Each image resource becomes a 1x1 image of the same format carrying its own resource name; each inlinedata:imagepayload in.tracestreams becomes a 1x1 image; every other entry keeps its bytes. Reducing the same source twice gives byte-identical zips.Sensitive data
Checked every non-image entry: only CI runner paths, the local fixture host and the-internet's public demo credentials. The original screenshots are gone.
Why this leaves #510 open
These cover one format: the one written until #508. Still open in #510: a fixture for each later format change as it ships, and a foreign trace, for which no zip was available.
Testing
pnpm build,pnpm test(3337 passed) andpnpm lintare green, on top of #508 and #513, so the current reader opens zips written before both.Screenshots / recordings
Not applicable: no UI change.
🤖 Generated with Claude Code