fix: fix CJS import of log
at session.ts
#875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is update for following TODO.
Updated package.json in "@wdio/electron-utils/log" to fix this TODO.
Memo
In my understand, when
CommonJS
is setmodule
attsconfig.json
, thenmoduleResolution
will be setnode10
(same asnode
) as a default.(docs)Then
exports
field of package.json(imported module side) will be ignored. (exports
field is added Node v12.7.0.)So this PR adds a
typesVersions
field and tells typescript to the appropriate types file.