Added GreenSun's WYSMTOD16A outdoor plug #277
Conversation
get_details and turn_on/turn_off working missing: get_energy
|
That you for the extensive PR, this is great work! Can you separate out adding the device into a separate PR, because it will take a while for me to review the other changes? |
|
Only by providing differences to master in a separate ZIP |
* upstream/master: fix: missing 131 data mapping Update VeSyncHumid200300S mode on update Bump version 2.1.16 Unifi 6000s to also return auto_humidity like other humidifiers Update VeSyncHumid200300S device_status on update
# By cdnninja (2) and others # Via GitHub (6) and Joe Trabulsy (1) * upstream/master: fix: missing 131 data mapping Update VeSyncHumid200300S mode on update Bump version 2.1.16 Unifi 6000s to also return auto_humidity like other humidifiers Update VeSyncHumid200300S device_status on update
|
@jmplonka I really appreciate the work that you've done here. I'm in the process of building the v2.0 in the dev-2.0 branch, which I've started to map out #284. If you would like to add the greensun plug to be included in the next release, please create a separate PR with only that change. Thank you again for making these edits, from what I reviewed they are a major improvement to the library, but I can't merge this without being confident that there are no breaking changes. If you would like to contribute structural changes, please break them into smaller PR's with the dev-2.0 branch that are more manageable to review. I'm happy to jump on discord and discuss what I am doing in parallel so there's no duplication of work. I'm going to leave this PR open if you would like to discuss, but I cannot merge. |
|
I'll create a new fork for this and commit only the changes required to support GreenSun plug with minimum impact. |
|
can you please check this changes: |
pyvesyncoutlet has lots of changes. Rework on other modules also. Please verify changes.
lates commits should be incorporated.