[scoped-custom-element-registry] Align patched HTMLElement with native inheritance #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the same inheritance safety measures already implemented in
native-shim.tsEnsures that instances of the patched HTMLElement have a
.constructorreference pointing to the patched constructor itself.Preserves the prototype chain by setting the patched constructor’s
[[Prototype]]to the native HTMLElement.Context
This issue was discovered in a very specific case involving legacy applications still using
custom-elements-es5-adapter.js, the old @open-wc/scoped-elements for Lit 1, and the new @open-wc/scoped-elements for Lit 3.