Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common tests #2474

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

mrginglymus
Copy link

@mrginglymus mrginglymus commented Dec 28, 2024

Adding a new test was a bit of a PITA due to the sheer number of libraries involved.

This proposed change (with example implementations in riot and react) moves all test definitions to a common location, with frameworks only having to invoke them with a set of factory functions.

This should hopefully make it easier to:

  1. Add a new test across all libraries (libraries missing implementations will gracefully skip)
  2. Add a new library (tests missing implementations will gracefully skip)
  3. Critically, ensure consistency of behaviour in tests

I can't see what skips will look like until #2475 is merged :)

I may pick off a few others to test this works, but I wont commit to completing until it's approved in principle.

@mrginglymus mrginglymus marked this pull request as ready for review December 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant