Skip to content

feat: webcam camera regions (size / focus / position) #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Reedaaz wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: webcam camera regions (size / focus / position) #531

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c23f43
@
Reedaaz May 16, 2026
7fbc675
feat(timeline): webcam regions default to full timeline duration
Reedaaz May 18, 2026
81710bb
fix(webcam-regions): resolve overlaps deterministically + clamp easin…
Reedaaz May 18, 2026
4b2a5d2
fix(webcam-regions): two-phase overlap resolution + unique fallback ids
Reedaaz May 18, 2026
7b08636
fix(webcam-regions): continuous blend across region boundary
Reedaaz May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ electron/native/bin/*/whisper-runtime.json
tmp-*.ps1
.tmp-*.ps1
gpu-export-probe.mp4
.claude/
17 changes: 10 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

256 changes: 174 additions & 82 deletions src/components/launch/hooks/useWebcamPreviewOverlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useCallback, useEffect, useRef, useState, type PointerEvent } from "react";
import { type PointerEvent, useCallback, useEffect, useRef, useState } from "react";
import { canShowFloatingWebcamPreview } from "../floatingWebcamPreview";
import { shouldRestoreHudMousePassthroughAfterDrag } from "../hudMousePassthrough";

const WEBCAM_PREVIEW_DRAG_THRESHOLD = 6;
const DEFAULT_WEBCAM_PREVIEW_OFFSET = { x: 0, y: 0 };
Expand All @@ -26,6 +27,7 @@ export function useWebcamPreviewOverlay({
const previewStreamRef = useRef<MediaStream | null>(null);
const previewDragMoveRafRef = useRef<number | null>(null);
const previewDragPendingPointerRef = useRef<{ clientX: number; clientY: number } | null>(null);
const previewDragWindowCleanupRef = useRef<(() => void) | null>(null);
const webcamPreviewDragStartRef = useRef<{
pointerId: number;
startX: number;
Expand Down Expand Up @@ -57,10 +59,130 @@ export function useWebcamPreviewOverlay({
}
webcamPreviewDragStartRef.current = null;
isWebcamPreviewDraggingRef.current = false;
previewDragWindowCleanupRef.current?.();
previewDragWindowCleanupRef.current = null;
setShowFloatingWebcamPreview(true);
}
}, [webcamEnabled]);

const updateWebcamPreviewDrag = useCallback(
(pointerId: number, clientX: number, clientY: number) => {
const dragState = webcamPreviewDragStartRef.current;
if (!dragState || dragState.pointerId !== pointerId) {
return;
}

const deltaX = clientX - dragState.startX;
const deltaY = clientY - dragState.startY;

if (!dragState.dragging && Math.hypot(deltaX, deltaY) < WEBCAM_PREVIEW_DRAG_THRESHOLD) {
return;
}

if (!dragState.dragging) {
dragState.dragging = true;
isWebcamPreviewDraggingRef.current = true;
}

previewDragPendingPointerRef.current = { clientX, clientY };
if (previewDragMoveRafRef.current !== null) {
return;
}

previewDragMoveRafRef.current = requestAnimationFrame(() => {
previewDragMoveRafRef.current = null;
const latestDragState = webcamPreviewDragStartRef.current;
const pointer = previewDragPendingPointerRef.current;
if (!latestDragState || !pointer) {
return;
}

const latestDeltaX = pointer.clientX - latestDragState.startX;
const latestDeltaY = pointer.clientY - latestDragState.startY;
const viewportWidth = Math.max(window.innerWidth, window.screen?.width ?? 0);
const viewportHeight = Math.max(window.innerHeight, window.screen?.height ?? 0);
const unclampedLeft = latestDragState.initialLeft + latestDeltaX;
const unclampedTop = latestDragState.initialTop + latestDeltaY;
const clampedLeft = Math.min(
Math.max(0, unclampedLeft),
Math.max(0, viewportWidth - latestDragState.previewWidth),
);
const clampedTop = Math.min(
Math.max(0, unclampedTop),
Math.max(0, viewportHeight - latestDragState.previewHeight),
);

const nextOffset = {
x: latestDragState.originX + (clampedLeft - latestDragState.initialLeft),
y: latestDragState.originY + (clampedTop - latestDragState.initialTop),
};
webcamPreviewOffsetRef.current = nextOffset;
if (recordingWebcamPreviewContainerRef.current) {
recordingWebcamPreviewContainerRef.current.style.transform = `translate(${nextOffset.x}px, ${nextOffset.y}px)`;
}
});
},
[],
);

const finishWebcamPreviewDrag = useCallback(
(
pointerId: number,
clientX: number,
clientY: number,
captureTarget?: HTMLDivElement | null,
) => {
const dragState = webcamPreviewDragStartRef.current;
if (!dragState || dragState.pointerId !== pointerId) {
return;
}

previewDragWindowCleanupRef.current?.();
previewDragWindowCleanupRef.current = null;

if (previewDragMoveRafRef.current !== null) {
cancelAnimationFrame(previewDragMoveRafRef.current);
previewDragMoveRafRef.current = null;
}
previewDragPendingPointerRef.current = null;

const wasDragging = dragState.dragging;
webcamPreviewDragStartRef.current = null;
isWebcamPreviewDraggingRef.current = false;
setWebcamPreviewOffset({ ...webcamPreviewOffsetRef.current });

if (captureTarget) {
try {
if (captureTarget.hasPointerCapture(pointerId)) {
captureTarget.releasePointerCapture(pointerId);
}
} catch {
// Chromium can drop pointer capture while Electron toggles mouse passthrough.
}
}

if (wasDragging) {
const bounds = recordingWebcamPreviewContainerRef.current?.getBoundingClientRect();
const shouldRestorePassthrough = shouldRestoreHudMousePassthroughAfterDrag(
bounds
? {
left: bounds.left,
top: bounds.top,
right: bounds.right,
bottom: bounds.bottom,
}
: null,
clientX,
clientY,
);
if (shouldRestorePassthrough) {
setTimeout(() => window.electronAPI?.hudOverlaySetIgnoreMouse?.(true), 0);
}
}
},
[],
);

const handleWebcamPreviewPointerDown = useCallback(
(event: PointerEvent<HTMLDivElement>) => {
if (event.button !== 0) {
Expand All @@ -71,6 +193,7 @@ export function useWebcamPreviewOverlay({

event.preventDefault();
window.electronAPI?.hudOverlaySetIgnoreMouse?.(false);
previewDragWindowCleanupRef.current?.();
webcamPreviewDragStartRef.current = {
pointerId: event.pointerId,
startX: event.clientX,
Expand All @@ -83,90 +206,55 @@ export function useWebcamPreviewOverlay({
previewHeight: previewRect.height,
dragging: false,
};
event.currentTarget.setPointerCapture(event.pointerId);
},
[],
);

const handleWebcamPreviewPointerMove = useCallback((event: PointerEvent<HTMLDivElement>) => {
const dragState = webcamPreviewDragStartRef.current;
if (!dragState || dragState.pointerId !== event.pointerId) {
return;
}

const deltaX = event.clientX - dragState.startX;
const deltaY = event.clientY - dragState.startY;

if (!dragState.dragging && Math.hypot(deltaX, deltaY) < WEBCAM_PREVIEW_DRAG_THRESHOLD) {
return;
}

if (!dragState.dragging) {
dragState.dragging = true;
isWebcamPreviewDraggingRef.current = true;
}

previewDragPendingPointerRef.current = { clientX: event.clientX, clientY: event.clientY };
if (previewDragMoveRafRef.current !== null) {
return;
}

previewDragMoveRafRef.current = requestAnimationFrame(() => {
previewDragMoveRafRef.current = null;
const latestDragState = webcamPreviewDragStartRef.current;
const pointer = previewDragPendingPointerRef.current;
if (!latestDragState || !pointer) {
return;
const target = event.currentTarget;
try {
target.setPointerCapture(event.pointerId);
} catch {
// Keep dragging through window listeners if pointer capture is unavailable.
}

const latestDeltaX = pointer.clientX - latestDragState.startX;
const latestDeltaY = pointer.clientY - latestDragState.startY;
const viewportWidth = Math.max(window.innerWidth, window.screen?.width ?? 0);
const viewportHeight = Math.max(window.innerHeight, window.screen?.height ?? 0);
const unclampedLeft = latestDragState.initialLeft + latestDeltaX;
const unclampedTop = latestDragState.initialTop + latestDeltaY;
const clampedLeft = Math.min(
Math.max(0, unclampedLeft),
Math.max(0, viewportWidth - latestDragState.previewWidth),
);
const clampedTop = Math.min(
Math.max(0, unclampedTop),
Math.max(0, viewportHeight - latestDragState.previewHeight),
);

const nextOffset = {
x: latestDragState.originX + (clampedLeft - latestDragState.initialLeft),
y: latestDragState.originY + (clampedTop - latestDragState.initialTop),
const handleWindowPointerMove = (moveEvent: globalThis.PointerEvent) => {
updateWebcamPreviewDrag(moveEvent.pointerId, moveEvent.clientX, moveEvent.clientY);
};
webcamPreviewOffsetRef.current = nextOffset;
if (recordingWebcamPreviewContainerRef.current) {
recordingWebcamPreviewContainerRef.current.style.transform = `translate(${nextOffset.x}px, ${nextOffset.y}px)`;
}
});
}, []);
const handleWindowPointerUp = (upEvent: globalThis.PointerEvent) => {
finishWebcamPreviewDrag(
upEvent.pointerId,
upEvent.clientX,
upEvent.clientY,
target,
);
};
window.addEventListener("pointermove", handleWindowPointerMove);
window.addEventListener("pointerup", handleWindowPointerUp);
window.addEventListener("pointercancel", handleWindowPointerUp);
previewDragWindowCleanupRef.current = () => {
window.removeEventListener("pointermove", handleWindowPointerMove);
window.removeEventListener("pointerup", handleWindowPointerUp);
window.removeEventListener("pointercancel", handleWindowPointerUp);
};
},
[finishWebcamPreviewDrag, updateWebcamPreviewDrag],
);

const handleWebcamPreviewPointerUp = useCallback((event: PointerEvent<HTMLDivElement>) => {
const dragState = webcamPreviewDragStartRef.current;
if (!dragState || dragState.pointerId !== event.pointerId) {
return;
}
if (previewDragMoveRafRef.current !== null) {
cancelAnimationFrame(previewDragMoveRafRef.current);
previewDragMoveRafRef.current = null;
}
previewDragPendingPointerRef.current = null;

const wasDragging = dragState.dragging;
webcamPreviewDragStartRef.current = null;
isWebcamPreviewDraggingRef.current = false;
setWebcamPreviewOffset({ ...webcamPreviewOffsetRef.current });
if (event.currentTarget.hasPointerCapture(event.pointerId)) {
event.currentTarget.releasePointerCapture(event.pointerId);
}
if (wasDragging) {
window.electronAPI?.hudOverlaySetIgnoreMouse?.(true);
}
}, []);
const handleWebcamPreviewPointerMove = useCallback(
(event: PointerEvent<HTMLDivElement>) => {
updateWebcamPreviewDrag(event.pointerId, event.clientX, event.clientY);
},
[updateWebcamPreviewDrag],
);

const handleWebcamPreviewPointerUp = useCallback(
(event: PointerEvent<HTMLDivElement>) => {
finishWebcamPreviewDrag(
event.pointerId,
event.clientX,
event.clientY,
event.currentTarget,
);
},
[finishWebcamPreviewDrag],
);

const attachPreviewStreamToNode = useCallback((videoElement: HTMLVideoElement | null) => {
const previewStream = previewStreamRef.current;
Expand Down Expand Up @@ -204,8 +292,12 @@ export function useWebcamPreviewOverlay({
if (previewDragMoveRafRef.current !== null) {
cancelAnimationFrame(previewDragMoveRafRef.current);
}
previewDragWindowCleanupRef.current?.();
previewDragWindowCleanupRef.current = null;
previewDragMoveRafRef.current = null;
previewDragPendingPointerRef.current = null;
webcamPreviewDragStartRef.current = null;
isWebcamPreviewDraggingRef.current = false;
};
}, []);

Expand All @@ -225,12 +317,12 @@ export function useWebcamPreviewOverlay({
width: { ideal: 320 },
height: { ideal: 320 },
frameRate: { ideal: 24, max: 30 },
}
}
: {
width: { ideal: 320 },
height: { ideal: 320 },
frameRate: { ideal: 24, max: 30 },
},
},
audio: false,
});

Expand Down
Loading