Skip to content

fix: macOS Safari capture and editor frame crashes #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ai-linor wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −19
Open

fix: macOS Safari capture and editor frame crashes #512

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
865ae26
fix(mac): fix Safari rendering black/white when using window capture
ai-linor May 13, 2026
1476ed7
fix(editor): prevent buggy frame extensions from crashing the entire …
ai-linor May 13, 2026
d7999ef
fix(mac): address coderabbit review feedback on capture display resol…
ai-linor May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions electron/native/ScreenCaptureKitRecorder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,17 @@ final class ScreenCaptureRecorder: NSObject, SCStreamOutput, SCStreamDelegate {
throw NSError(domain: "RecordlyCapture", code: 3, userInfo: [NSLocalizedDescriptionKey: "Window not found"])
}

filter = SCContentFilter(desktopIndependentWindow: window)

let candidateDisplay = availableContent.displays.first(where: {
$0.frame.intersects(window.frame) || $0.frame.contains(CGPoint(x: window.frame.midX, y: window.frame.midY))
})
let scaleFactor = ScreenCaptureRecorder.scaleFactor(for: candidateDisplay?.displayID ?? CGMainDisplayID())
}) ?? availableContent.displays.first

guard let display = candidateDisplay else {
throw NSError(domain: "RecordlyCapture", code: 4, userInfo: [NSLocalizedDescriptionKey: "No display found for window"])
}

filter = SCContentFilter(display: display, including: [window], exceptingApplications: [], exceptingWindows: [])

let scaleFactor = ScreenCaptureRecorder.scaleFactor(for: display.displayID)
outputWidth = max(2, Int(window.frame.width) * scaleFactor)
outputHeight = max(2, Int(window.frame.height) * scaleFactor)
if #available(macOS 14.0, *) {
Expand Down