Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Update formatTransaction to not delete data property #6080

Merged
merged 8 commits into from
May 16, 2023

Conversation

spacesailor24
Copy link
Contributor

closes #6074

@spacesailor24 spacesailor24 self-assigned this May 10, 2023
@spacesailor24 spacesailor24 added the 4.x 4.0 related label May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 642 KB 642 KB 92 bytes 0.01%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 625 KB 625 KB 92 bytes 0.01%
../lib/commonjs/index.d.ts 8.43 KB 8.43 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.37 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 808 bytes 808 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83cd4ea
Status: ✅  Deploy successful!
Preview URL: https://b6ad8c1e.web3-js-docs.pages.dev
Branch Preview URL: https://wyatt-4-x-6074-send-tx-data.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #6080 (83cd4ea) into 4.x (ae1d156) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6080      +/-   ##
==========================================
+ Coverage   87.59%   87.62%   +0.02%     
==========================================
  Files         199      199              
  Lines        7564     7570       +6     
  Branches     2045     2049       +4     
==========================================
+ Hits         6626     6633       +7     
+ Misses        938      937       -1     
Flag Coverage Δ
UnitTests 87.62% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@spacesailor24 spacesailor24 merged commit 072a968 into 4.x May 16, 2023
@spacesailor24 spacesailor24 deleted the wyatt/4.x/6074-send-tx-data-input branch May 16, 2023 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_sendTransaction data vs input
3 participants