Skip to content

fix: "ERR_INVALID_THIS" on Node 20 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: "ERR_INVALID_THIS" on Node 20 #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e55e8cf
fix(CI): stop testing on Node 14
MichaelDeBoey Apr 7, 2025
2e0c3e0
fix: "ERR_INVALID_THIS" on Node 20 (#32)
mcansh Apr 20, 2023
6dd7b5b
chore: fix changeset
MichaelDeBoey Aug 26, 2023
38723e1
chore: update internal versions
mcansh Aug 31, 2023
c5f7708
chore: update internal versions
MichaelDeBoey Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-eggs-jam.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@web-std/fetch": patch
---

fixes "ERR_INVALID_THIS" on Node 20
13 changes: 8 additions & 5 deletions .github/workflows/blob.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,17 @@ jobs:
name: Typecheck
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 16
project:
- blob
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -42,10 +43,12 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -54,10 +57,10 @@ jobs:
- blob

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
26 changes: 8 additions & 18 deletions .github/workflows/fetch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,17 @@ jobs:
name: Typecheck
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 16
project:
- fetch
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -44,28 +45,24 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
- macos-latest
project:
- fetch
exclude:
- os: windows-latest
node-version: 14
# On macOS, run tests with only the LTS environments.
- os: macos-latest
node-version: 14

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -75,12 +72,5 @@ jobs:
- name: Test (ESM)
run: yarn --cwd packages/${{matrix.project}} test -- --colors

# upload coverage only once
- name: Coveralls
uses: coverallsapp/github-action@master
if: matrix.node == '14' && matrix.os == 'ubuntu-latest'
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Test (CJS)
run: yarn --cwd packages/${{matrix.project}} test:cjs
13 changes: 8 additions & 5 deletions .github/workflows/file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,17 @@ jobs:
name: Typecheck
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 16
project:
- file
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -42,10 +43,12 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -54,10 +57,10 @@ jobs:
- file

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/form-data.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,17 @@ jobs:
name: Typecheck
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 16
project:
- form-data
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -43,10 +44,12 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -55,10 +58,10 @@ jobs:
- form-data

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
18 changes: 11 additions & 7 deletions .github/workflows/stream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,18 @@ jobs:
name: Typecheck
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 16
project:
- stream
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -43,10 +44,12 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -56,10 +59,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -76,6 +79,7 @@ jobs:
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
node-version:
- 16
Expand All @@ -84,10 +88,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 16

Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"name": "@web-std/io",
"private": true,
"workspaces": [
"packages/blob",
Expand Down
4 changes: 2 additions & 2 deletions packages/blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@
},
"dependencies": {
"web-encoding": "1.1.5",
"@web-std/stream": "1.0.0"
"@web-std/stream": "^1.0.3"
},
"author": "Irakli Gozalishvili <[email protected]> (https://gozala.io)",
"repository": "https://github.com/web-std/io",
"license": "MIT",
"devDependencies": {
"@types/node": "15.0.2",
"@web-std/fetch": "^3.0.0",
"@web-std/fetch": "^4.2.1",
"git-validate": "2.2.4",
"husky": "^6.0.0",
"lint-staged": "^11.0.0",
Expand Down
12 changes: 0 additions & 12 deletions packages/fetch/.github/FUNDING.yml
View file
Open in desktop

This file was deleted.

40 changes: 0 additions & 40 deletions packages/fetch/.github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/fetch/.github/ISSUE_TEMPLATE/config.yml
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions packages/fetch/.github/ISSUE_TEMPLATE/feature-request.md
View file
Open in desktop

This file was deleted.

Loading
Loading