Test SpeechSynthesisUtterance volume attribute #9963

guest271314 · 2018-03-12T02:49:54Z

TODO: automate test to verify audio output of speechSynthesis.speak() using Web Audio API.

ghost · 2018-03-12T02:56:36Z

Build ERRORED

Started: 2018-03-12 02:50:28
Finished: 2018-03-12 02:56:35

Failing Jobs

lint
chrome:dev
safari:11.0
MicrosoftEdge:16.16299

View more information about this build on:

guest271314 · 2018-03-16T15:35:29Z

@andrenatal @fleizach @gshires @jdsmith3000

What needs to be done to add this test to speech-api folder at this repository?

guest271314 · 2018-05-28T23:08:06Z

@foolip Can this test be merged into the speech-api tests directory?

foolip · 2018-05-31T15:54:18Z

Please have a look at https://web-platform-tests.org/writing-tests/manual.html for some tips for manual tests, in particular the test needs to make it clear to the person running it what is passing and not. For example, you might try to utter the "FAIL" with volume 0, then the word "PASS" with volume 1, and instructions say that the test passes if you only hear the PASS.

MediaSource crashes tab at Chromium/Chrome References: #15816 https://bugs.chromium.org/p/chromium/issues/detail?id=820997 https://github.com/guest271314/MediaFragmentRecorder

Outputs expected result at Firefox. Crashes tab at Chromium/Chrome #15816

…diaelement-capturestream Test HTMLMediaElement.captureStream()

…ce-htmlmediaelement-capturestream Revert "Test HTMLMediaElement.captureStream()"

foolip · 2019-03-22T13:20:22Z

@guest271314 did you accidentally merge in more stuff to this PR? Did you have a look at https://web-platform-tests.org/writing-tests/manual.html? Sorry this has been sitting for so long, but it hasn't come up in my inbox because nothing happened until now.

guest271314 · 2019-03-22T17:01:44Z

@foolip It took a few days to get this PR here. Did not intentionally include the Web Speech API .volume test, again; as there is already an open PR for that test. Would probably still not be here without the help of @jdm #15816 (comment).

Will try to not to state the issues at GitHub to prevent being banned here as well people tend to get emotional when talking to them without kid gloves on re their "platform"; and have already been redirected to some page that states "abuse" of the site by simply searching, after the recent acquisition of the site.

Does the test need to be written according to the linked manual test page? And then, does this PR need to be closed and a new PR opened? Can you provide the complete steps necessary for this PR to be incorporated into wpt, to avoid eventually filing another issue for the purpose of navigating this site and git process to get to that point?

guest271314 · 2019-03-22T17:18:45Z

@foolip Does the manual test need to include buttons for both "PASS" and "FAIL"?

foolip · 2019-04-01T10:05:12Z

@guest271314 you don't need to have any buttons in the test itself, just instructions that are visible when opening the page that say what the user should do to judge whether it passes or not. Right now that's in JS comments, so putting the instructions in HTML would be good.

Other than that, you just need to get rid of the extra commits so that there's just one file remaining. If you don't want to deal with git rebase and would rather just edit the test in GitHub's UI, I can get rid of the extra file when merging instead.

guest271314 · 2019-04-01T16:10:32Z

@foolip Is this appropriate?

<!DOCTYPE html>
<html>
<head>
  <title>5.2.3 SpeechSynthesisUtterance volume attribute test - manual</title>
  <script>
var text = "hello universe";
var volumes = [0, 0.16666666666666666, 0.3333333333333333, 0.5, 0.6666666666666666, 0.8333333333333333, 0.9999999999999999];
 window.speechSynthesis.cancel();
 function handleVoicesChanged() {
  volumes.forEach(function(volume) {
    var utterance = new SpeechSynthesisUtterance();
    utterance.text = "hello universe";  
    utterance.volume = volume;
    window.speechSynthesis.speak(utterance);
  });
};
window.speechSynthesis.onvoiceschanged = handleVoicesChanged;
window.speechSynthesis.getVoices();
</script>
</head>
<body>
<p>
Specification

https://w3c.github.io/speech-api/speechapi.html#utterance-attributes

volume attribute

This attribute specifies the speaking volume for the utterance. 
It ranges between 0 and 1 inclusive, with 0 being the lowest volume and 1 the highest volume, with a default of 1. 
If SSML is used, this value will be overridden by prosody tags in the markup.
</p>
<p>
Test

Does the volume of audio output change?
</p>
</body>
</html>

If so, what needs to be done? Place that HTML in own fork and make another PR? Or can the code in this PR be changed?

foolip · 2019-05-06T11:03:50Z

@guest271314 yes you can update the code in this PR by updating the master branch of your fork, since that's the branch used to create this PR. Or, if you find it simpler, you can just send another PR.

In the code you pasted, using the voiceschanged event looks unnecessary, can't the test just start calling speechSynthesis.speak right away?

guest271314 · 2019-05-06T14:33:39Z

@foolip Has been several OS's ago since dove into Web Speech API. speak() communicates with the local Speech Dispatcher server https://github.com/brailcom/speechd. At Chromium if no voices are loaded an empty array could be returned for getVoices(), see https://stackoverflow.com/q/46863170. Chrome is shipped with voices created by *oogle. Though the code base is Chromium source, Chromium is not shipped with the custom *oogle voices. Yes, would suggest to use onvoiceschanged event. It is not straightforward how the procedure works in the specification.

Have to get the code working again, locally, which may require setting up Speech Dispatcher server again. Been a while since mapped a flow chart of how to use Web Speech API.

Have not, in general, had success filing PR's. Something invariably is included or not included which should or should not have been included. Will try to make sure the code still works at Chromium and update this PR over the next couple days.

guest271314 · 2019-05-06T15:05:48Z

@foolip Another consideration that needs to be taken into account is that autoplay policies of browsers have changed since this PR was initially filed, e.g., guest271314/SpeechSynthesisRecorder#13

guest271314 · 2019-05-06T23:58:30Z

@foolip Updated the code at f580334. Tested at Firefox 66 and Chromium 73. Will try at Nightly 68 within a day or so. The volume does appear to change at Firefox, not at Chromium plnkr https://plnkr.co/edit/iV2DdU?p=preview.

guest271314 · 2019-05-07T00:13:46Z

@foolip Note, for the code to have audio output at Chromium at *nix espeak, espeak-ng or other TTS program needs to be installed and configured to be used with speech-dispatcher, and Chromium needs to be launched with --enable-speech-dispatcher flag.

speech-api/SpeechSynthesisUtterance-volume-attribute-test-manual.html

mediacapture-fromelement/testRecordingMediaFragmentsWithMediaSourceAndMediaRecorder.html

Delete testRecordingMediaFragmentsWithMediaSourceAndMediaRecorder.html from PR including Web Speech API test

guest271314 · 2019-05-08T15:07:07Z

@foolip Made the suggested changes to the code.

…SpeechSynthesisUtterance-volume-manual.html

guest271314

@foolip There is a syntax error at closing </html> tag

foolip · 2019-05-08T15:51:55Z

@guest271314 I fixed that (and a blank line, and the filename) before merging.

guest271314 · 2019-05-09T00:30:49Z

@foolip const text = "hello universe" is not used.

foolip · 2019-05-09T06:06:24Z

@guest271314 can you send another PR to fix?

guest271314 · 2019-05-09T15:16:14Z

@foolip Still not versed enough yet with how to make a PR using the GitHub GUI. Tried for at least an hour yesterday to create a PR for the deleted (from this PR) MediaSource/HTMLMediaElement.captureStream() test. Every time the displayed output was, paraphrasing, "nothing to compare". Will continue to try.

guest271314 · 2019-05-09T15:31:52Z

@foolip Following the suggestion of @jdm at #15816 (comment) was helpful though led to multiple PR's being incorporated into this PR (which had to delete files from). master...guest271314:master is the link from that comment. How to "clean up" the multiple PR sources to both update this PR (the code) and separately file the PR which tests capturing <video> using .captureStream() where src attribute is set to MediaSource instance?

foolip · 2019-05-09T16:43:01Z

@guest271314, if you want to edit a single file and create a new PR, navigate to it from https://github.com/web-platform-tests/wpt?files=1 and then edit, you'll be at a URL like this:
https://github.com/web-platform-tests/wpt/edit/master/speech-api/SpeechSynthesisUtterance-volume-manual.html

Then just write a commit message and create the PR.

guest271314 · 2019-05-09T16:55:41Z

@foolip Filed updated PR. How to file the PR for the MediaSource/HTMLMediaElement.captureStream() test cc69d84 ?

guest271314 · 2019-05-09T17:18:26Z

@foolip These are the two commits that am trying to file a PR for each 4ec6753 and cc69d84. The former is for the mediacapture-fromelement directory the latter is for media-source directory.

guest271314 · 2019-05-09T18:35:53Z

@foolip This is the filed PR #16756. Probably needs some cleaning up, though not sure how to do so

Test SpeechSynthesisUtterance volume attribute

0fdd236

TODO: automate test to verify audio output of speechSynthesis.speak() using Web Audio API.

wpt-pr-bot added the speech-api label Mar 12, 2018

wpt-pr-bot requested review from andrenatal, fleizach and gshires May 31, 2018 15:54

MediaSource crashes tab at Chromium/Chrome

4ec6753

MediaSource crashes tab at Chromium/Chrome References: #15816 https://bugs.chromium.org/p/chromium/issues/detail?id=820997 https://github.com/guest271314/MediaFragmentRecorder

wpt-pr-bot added mediacapture-fromelement wg-das wg-webrtc labels Mar 18, 2019

wpt-pr-bot assigned foolip Mar 18, 2019

wpt-pr-bot requested review from foolip, martinthomson, uysalere and yell0wd0g and removed request for fleizach March 18, 2019 19:06

wpt-pr-bot added media-source wg-html labels Mar 18, 2019

wpt-pr-bot requested a review from wolenetz March 18, 2019 19:25

guest271314 added 4 commits March 20, 2019 02:58

Test HTMLMediaElement.captureStream()

cc69d84

Outputs expected result at Firefox. Crashes tab at Chromium/Chrome #15816

Merge pull request #2 from guest271314/guest271314-mediasource-htmlme…

20ee21b

…diaelement-capturestream Test HTMLMediaElement.captureStream()

Revert "Test HTMLMediaElement.captureStream()"

25493ae

Merge pull request #3 from guest271314/revert-2-guest271314-mediasour…

c55991f

…ce-htmlmediaelement-capturestream Revert "Test HTMLMediaElement.captureStream()"

Update WPT Manual Test

f580334

foolip reviewed May 8, 2019

View reviewed changes

guest271314 added 2 commits May 8, 2019 14:11

Delete MediaSource-MediaStream test

1bf8669

Delete testRecordingMediaFragmentsWithMediaSourceAndMediaRecorder.html from PR including Web Speech API test

Update SpeechSynthesisUtterance-volume-attribute-test-manual.html

8568526

foolip added 2 commits May 8, 2019 17:08

Rename SpeechSynthesisUtterance-volume-attribute-test-manual.html to …

1a765a5

…SpeechSynthesisUtterance-volume-manual.html

Update SpeechSynthesisUtterance-volume-manual.html

80a2259

foolip approved these changes May 8, 2019

View reviewed changes

foolip merged commit d6c1c77 into web-platform-tests:master May 8, 2019

guest271314 commented May 8, 2019

View reviewed changes

marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019

Test SpeechSynthesisUtterance volume attribute (#9963)

d255b4e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test SpeechSynthesisUtterance volume attribute #9963

Test SpeechSynthesisUtterance volume attribute #9963

guest271314 commented Mar 12, 2018 •

edited by wpt-pr-bot

Loading

ghost commented Mar 12, 2018

guest271314 commented Mar 16, 2018

guest271314 commented May 28, 2018

foolip commented May 31, 2018

foolip commented Mar 22, 2019

guest271314 commented Mar 22, 2019

guest271314 commented Mar 22, 2019

foolip commented Apr 1, 2019

guest271314 commented Apr 1, 2019

foolip commented May 6, 2019

guest271314 commented May 6, 2019

guest271314 commented May 6, 2019

guest271314 commented May 6, 2019

guest271314 commented May 7, 2019

guest271314 commented May 8, 2019

guest271314 left a comment

foolip commented May 8, 2019

guest271314 commented May 9, 2019

foolip commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented May 9, 2019

foolip commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented May 9, 2019

Test SpeechSynthesisUtterance volume attribute #9963

Test SpeechSynthesisUtterance volume attribute #9963

Conversation

guest271314 commented Mar 12, 2018 • edited by wpt-pr-bot Loading

ghost commented Mar 12, 2018

Build ERRORED

Failing Jobs

guest271314 commented Mar 16, 2018

guest271314 commented May 28, 2018

foolip commented May 31, 2018

foolip commented Mar 22, 2019

guest271314 commented Mar 22, 2019

guest271314 commented Mar 22, 2019

foolip commented Apr 1, 2019

guest271314 commented Apr 1, 2019

foolip commented May 6, 2019

guest271314 commented May 6, 2019

guest271314 commented May 6, 2019

guest271314 commented May 6, 2019

guest271314 commented May 7, 2019

guest271314 commented May 8, 2019

guest271314 left a comment

Choose a reason for hiding this comment

foolip commented May 8, 2019

guest271314 commented May 9, 2019

foolip commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented May 9, 2019

foolip commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented May 9, 2019

guest271314 commented Mar 12, 2018 •

edited by wpt-pr-bot

Loading