Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the geometry IDL file #9787

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Update the geometry IDL file #9787

merged 3 commits into from
Mar 29, 2018

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Mar 2, 2018 •
edited by wpt-pr-bot
Loading

No description provided.

@wpt-pr-bot wpt-pr-bot requested review from domenic, jensl and yuki3 March 2, 2018 19:31
@lukebjerring lukebjerring force-pushed the idl-file-updates-geometry branch from 525064b to 7056328 Compare March 2, 2018 21:52
@ghost
Copy link

ghost commented Mar 2, 2018 •
edited by ghost
Loading

Build PASSED

Started: 2018-03-23 13:52:21
Finished: 2018-03-23 14:00:45

View more information about this build on:

@lukebjerring lukebjerring force-pushed the idl-file-updates-geometry branch from 7056328 to 321012a Compare March 7, 2018 20:23
foolip
foolip approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing [NoInterfaceObject] \o/

@foolip foolip mentioned this pull request Mar 9, 2018
Open
@foolip
Copy link
Member

foolip commented Mar 9, 2018

These changes are good, but looking at https://pulls.web-platform-tests.org/build/25659 I realize we have a problem: we're not running any tests when updating the IDL files even though locally wpt tests-affected does list css/cssom-view/interfaces.html. It doesn't list css/geometry/interfaces.html because an indirection via css/geometry/support/interfaces.js.

So, um... filed web-platform-tests/pulls.web-platform-tests.org#61 for the fact that the results for Firefox weren't saved even though they did run. Tested https://web-platform.test:8443/css/geometry/interfaces.html locally, and we get new harness error:

3 duplicate test names: "Test default toJSON operation of DOMPointReadOnly", "Test default toJSON operation of DOMRectReadOnly", "Test default toJSON operation of DOMMatrixReadOnly"

@foolip
Copy link
Member

foolip commented Mar 9, 2018

Sigh, I'm pretty sure this is just something that idlharness.js doesn't get right, and we need to fix before merging this. Not filing an issue for now.

@lukebjerring lukebjerring mentioned this pull request Mar 14, 2018
Merged
@lukebjerring lukebjerring force-pushed the idl-file-updates-geometry branch from 5e2df51 to 7ab9a09 Compare March 14, 2018 13:55
@lukebjerring
Copy link
Contributor Author

7ab9a09 handles one of the duplicate test name causes, and
#10029 handles the other, though needs review.

@lukebjerring lukebjerring force-pushed the idl-file-updates-geometry branch from 7ab9a09 to 3982bf8 Compare March 23, 2018 13:51
@lukebjerring lukebjerring merged commit a149250 into web-platform-tests:master Mar 29, 2018
@lukebjerring lukebjerring deleted the idl-file-updates-geometry branch March 29, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@domenic domenic Awaiting requested review from domenic

@jensl jensl Awaiting requested review from jensl

@yuki3 yuki3 Awaiting requested review from yuki3

@dirkschulze dirkschulze Awaiting requested review from dirkschulze

@peterjoel peterjoel Awaiting requested review from peterjoel

@tschneidereit tschneidereit Awaiting requested review from tschneidereit

Assignees
No one assigned
Labels
geometry interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukebjerring @foolip @wpt-pr-bot