Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Edge 16 in Travis builds #9338

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Use Edge 16 in Travis builds #9338

merged 1 commit into from
Feb 1, 2018
+2 −2

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 1, 2018 •
edited by wpt-reviewable-bot
Loading

This change is Reviewable

@ghost
Copy link

ghost commented Feb 1, 2018 •
edited by ghost
Loading

Build PASSED

Started: 2018-02-01 14:43:49
Finished: 2018-02-01 14:50:40

View more information about this build on:

@foolip foolip mentioned this pull request Feb 1, 2018
Open
@foolip
Copy link
Member Author

foolip commented Feb 1, 2018

I've filed web-platform-tests/pulls.web-platform-tests.org#58 about the weird thing that seems to be going on with the @w3c-bots comment.

I was hoping that https://pulls.web-platform-tests.org/job/23710.13 (the Edge link) would have shown that this works by listing the tests that ran successfully, but it doesn't work due to web-platform-tests/pulls.web-platform-tests.org#47.

Anyway, expanding https://travis-ci.org/w3c/web-platform-tests/jobs/336008126#L662 shows that this has worked, and the test results show nothing surprising, some things passing some things failing, the same as before.

Assigning to @mattl and @jugglinmike to review and merge.

Ms2ger
Ms2ger requested changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but revert the REVERTME commit.

@foolip
Copy link
Member Author

foolip commented Feb 1, 2018

I have dropped the REVERTME commit.

jugglinmike
jugglinmike approved these changes Feb 1, 2018
View reviewed changes
Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress!

@jugglinmike jugglinmike merged commit bb1a4a2 into master Feb 1, 2018
@foolip foolip deleted the edge-16-travis branch February 1, 2018 17:48
@foolip
Copy link
Member Author

foolip commented Feb 1, 2018

As an aside, this means it's also possible to run Edge 16 for wpt.fyi without any own hardware. Nice to have that choice I guess.

@foolip foolip mentioned this pull request Feb 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugglinmike jugglinmike jugglinmike approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

@atanassov atanassov Awaiting requested review from atanassov

@ayg ayg Awaiting requested review from ayg

@cbiesinger cbiesinger Awaiting requested review from cbiesinger

@chenxix chenxix Awaiting requested review from chenxix

@fantasai fantasai Awaiting requested review from fantasai

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@kojiishi kojiishi Awaiting requested review from kojiishi

@mrego mrego Awaiting requested review from mrego

@plinss plinss Awaiting requested review from plinss

@tabatkins tabatkins Awaiting requested review from tabatkins

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@jugglinmike jugglinmike

Labels
css-flexbox dom html infra wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foolip @Ms2ger @jugglinmike @mattl @wpt-pr-bot