Skip to content

test(webxr): ensure setViewerOrigin(null) throws TypeError #55819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

test(webxr): ensure setViewerOrigin(null) throws TypeError #55819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
719111c
test(webxr): ensure setViewerOrigin(null) throws TypeError
prasanth-30011 Nov 2, 2025
ed5cba1
Merge pull request #1 from prasanth-30011/fix/webxr-viewerOrigin-null
prasanth-30011 Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions webxr/xrFrame_getViewerPose_getPose_identities.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@
}

const testFunction = function(session, fakeDeviceController, t) {
// Verify that setting viewerOrigin to null throws TypeError per spec.
t.step(() => {
assert_throws_js(TypeError, () => {
// fakeDeviceController is supplied to the test and should expose the method
// that the implementation uses to set the viewer origin. If the API name
// differs, adapt this call accordingly.
fakeDeviceController.setViewerOrigin(null);
}, "fakeDeviceController.setViewerOrigin(null) should throw TypeError");
});

return Promise.all([
session.requestReferenceSpace('local'),
session.requestReferenceSpace('viewer'),
Expand Down