[Masonry] Use max-content for stacking axis min-content #55809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the proposal in [1], "Have the min-content size of the stacking axis of a masonry container be the same as its max-content size (same as the "stacking axis" of block layout)." This CL implements this proposal and updates the expectation of the test that kicked of this issue originally. It also fixes crashes in a few tests where orthogonal items in a row masonry had a larger min-content size than max-content size, leading to a check that expected the container min-content to be <= to the max-content size. [1] w3c/csswg-drafts#12843 (comment) Bug: 343257585 Change-Id: I35eab974b3518968ee4d686dfbc0adafa43f9a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7107410 Reviewed-by: Ian Kilpatrick <[email protected]> Commit-Queue: Alison Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1539388}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7107410
branch
from
9e2c20d to
82c4b7e
Compare
wpt-pr-bot
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the proposal in [1], "Have the min-content size of the stacking
axis of a masonry container be the same as its max-content size (same
as the "stacking axis" of block layout)."
This CL implements this proposal and updates the expectation of the
test that kicked of this issue originally. It also fixes crashes in a
few tests where orthogonal items in a row masonry had a larger
min-content size than max-content size, leading to a check that
expected the container min-content to be <= to the max-content size.
[1] w3c/csswg-drafts#12843 (comment)
Bug: 343257585
Change-Id: I35eab974b3518968ee4d686dfbc0adafa43f9a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7107410
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Alison Maher <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1539388}