Make label click WPT stop timing out #49856
Merged
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch refactors a WPT to expect a click event after waiting for test_driver to complete its inputs instead of just waiting forever for a click event. As a result, it is clearer that this test is only failing on content_shell due to functionality within test_driver. Bug: 40756672 Change-Id: Id3debff7f74c8db9e0c30c9fadcae60a54a10755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6126506 Reviewed-by: Di Zhang <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1400951}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6126506
branch
from
a60fa75 to
07fb186
Compare
wpt-pr-bot
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors a WPT to expect a click event after waiting for
test_driver to complete its inputs instead of just waiting forever for a
click event.
As a result, it is clearer that this test is only failing on
content_shell due to functionality within test_driver.
Bug: 40756672
Change-Id: Id3debff7f74c8db9e0c30c9fadcae60a54a10755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6126506
Reviewed-by: Di Zhang <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1400951}