[wdspec] verify internal ids for deeply nested objects #49821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
OrKoN
force-pushed
the
orkon/nested-objects
branch
from
0bbe051 to
dd96b01
Compare
Bowlin1977
approved these changes
Dec 23, 2024
whimboo
approved these changes
Dec 30, 2024
Comment on lines
+76
to
+83
| # key1 | ||
| internalIdKey1 = result["value"][0][1]["internalId"] | ||
| # key2 | ||
| internalIdKey2 = result["value"][1][1]["internalId"] | ||
| # nested.key3 | ||
| internalIdKey3 = result["value"][2][1]["value"][0][1]["internalId"] | ||
| # nested.key4 | ||
| internalIdKey4 = result["value"][2][1]["value"][1][1]["internalId"] |
There was a problem hiding this comment.
I think that we can remove the 4 comments here given that it is clear by the name of the variables what these are used for.
Suggested change
| # key1 | |
| internalIdKey1 = result["value"][0][1]["internalId"] | |
| # key2 | |
| internalIdKey2 = result["value"][1][1]["internalId"] | |
| # nested.key3 | |
| internalIdKey3 = result["value"][2][1]["value"][0][1]["internalId"] | |
| # nested.key4 | |
| internalIdKey4 = result["value"][2][1]["value"][1][1]["internalId"] | |
| internalIdKey1 = result["value"][0][1]["internalId"] | |
| internalIdKey2 = result["value"][1][1]["internalId"] | |
| internalIdKey3 = result["value"][2][1]["value"][0][1]["internalId"] | |
| internalIdKey4 = result["value"][2][1]["value"][1][1]["internalId"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests never verify that serialization of deeply (more than 1 level) objects actually works.