webnn: Make MLOperandDescriptor.shape a required dictionary member #48637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See webmachinelearning/webnn#758 Also removes the temporary support for passing "dimensions" which was added in https://crrev.com/e7e99aa5 Bug: 365813262 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,win11-blink-rel Change-Id: Ib714ae540da7fbd7d55365dc739bfb8dbf266406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850659 Reviewed-by: ningxin hu <[email protected]> Commit-Queue: ningxin hu <[email protected]> Auto-Submit: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369192}
wpt-pr-bot
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See webmachinelearning/webnn#758
Also removes the temporary support for passing "dimensions" which was
added in https://crrev.com/e7e99aa5
Bug: 365813262
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,win11-blink-rel
Change-Id: Ib714ae540da7fbd7d55365dc739bfb8dbf266406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850659
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1369192}