webnn: Give an MLBuffer an MLOperandDescriptor #46770
Merged
+279
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5604163
branch
from
b196533 to
f362739
Compare
This CL gives MLBufferDescriptor an MLOperandDescriptor as per webmachinelearning/webnn#542 To represent this descriptor, this CL also creates a new typemapped OperandDescriptor type which ensures that the buffer descriptor is valid. OperandDescriptor will be used more pervasively within WebNN in follow-up CLs 1) Move Operand::DataType to DataType (MERGED) 2) Create a typemapped OperandDescriptor class for MLBuffer <-- this CL 3) Use OperandDescriptor in mojom::Operand 4+) Remove duplicate code (especially with //components) Fuchsia binary size seems to be unavoidable for now, and I suspect may be temporary once duplicate code is removed in follow-ups. bloaty shows a binary size increase primarily in //t/b/r/m/ml/webnn/ml_graph_type_converter.cc, as well as a handful of other renderer-side files which depend on the mojom component Bug: 343638938, 325598628 Fuchsia-Binary-Size: See commit description Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Change-Id: I775340f5c5e0e80942332cbae750d0d305cdd458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5604163 Reviewed-by: ningxin hu <[email protected]> Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Alex Gough <[email protected]> Reviewed-by: Reilly Grant <[email protected]> Cr-Commit-Position: refs/heads/main@{#1315553}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5604163
branch
from
f362739 to
c0fde9f
Compare
wpt-pr-bot
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL gives MLBufferDescriptor an MLOperandDescriptor as per
webmachinelearning/webnn#542
To represent this descriptor, this CL also creates a new typemapped
OperandDescriptor type which ensures that the buffer descriptor is
valid. OperandDescriptor will be used more pervasively within WebNN
in follow-up CLs
4+) Remove duplicate code (especially with //components)
Fuchsia binary size seems to be unavoidable for now, and I suspect
may be temporary once duplicate code is removed in follow-ups.
bloaty shows a binary size increase primarily in
//t/b/r/m/ml/webnn/ml_graph_type_converter.cc, as well as a handful
of other renderer-side files which depend on the mojom component
Bug: 343638938, 325598628
Fuchsia-Binary-Size: See commit description
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Change-Id: I775340f5c5e0e80942332cbae750d0d305cdd458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5604163
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1315553}