Add a headless mode command line option #13076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For browsers which support headless mode starting wptrunner with --headless will run the tests in headless mode; otherwise it will be ignored. --no-headless is avaiable to explicitly disable the mode when frontends change the defaults. For firefox switch the default for wpt run to be headless; for Chrome changing the default broke some smoketests, so don't switch until that is resolved. In all cases continue to run in a normal windowed mode in CI.
wpt-pr-bot
added
ci
infra
wpt
wptrunner
Hexcles
reviewed
Sep 19, 2018
| config_group.add_argument("--headless", action="store_true", | ||
| help="Run browser in headless mode", default=None) | ||
| config_group.add_argument("--no-headless", action="store_false", dest="headless", | ||
| help="Don't run browser in headless mode") |
There was a problem hiding this comment.
Can we clarify what the default behaviour is in the help text?
There was a problem hiding this comment.
Weirdly, not easily. Becausewpt run sets its own per-browser default. So we'd have to override the help text in that case.
|
Fixes #13076 and related to web-platform-tests/results-collection#603 |
Is there a bug filed for the Chrome issue? |
|
It's much easier to file a bug if we merge this because it gives simpler STR. |
Hexcles
approved these changes
Sep 24, 2018
tools/wpt/run.py
Outdated
| # Allow WebRTC tests to call getUserMedia. | ||
| kwargs["extra_prefs"].append("media.navigator.streams.fake=true") | ||
|
|
||
|
|
||
|
|
jugglinmike
added a commit
to bocoup/results-collection
that referenced
this pull request
Sep 24, 2018
As of [1] (merged on 2018-09-24), the WPT CLI enables the "headless" mode of Chrome and Firefox by default. This mode is more convenient for contributors running the tests from their development system, but it also relies on functionality which is not enabled during typical usage of the browsers. Results collected in this mode are therefore less authentic than results collected using a virtual display. @jgraham commented on this in [2]: > unless we have some reasonable assurance that headless mode matches > non-headless in all cases (e.g. the relevant browser running both > configurations in CI with identical results) I don't think we should > enable it for wpt.fyi-ingested runs. That issue includes evidence that the results are not equivalent, meaning "headless" mode is not appropriate for publicly documenting the capabilities of each browser. Extend the results collection system to use the new `--no-headless` command-line argument. [1] web-platform-tests/wpt#13076 [2] web-platform-tests#603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For browsers which support headless mode starting wptrunner with
--headless will run the tests in headless mode; otherwise it will be
ignored.
--no-headless is avaiable to explicitly disable the mode when
frontends change the defaults.
For firefox switch the default for wpt run to be headless; for Chrome
changing the default broke some smoketests, so don't switch until that
is resolved. In all cases continue to run in a normal windowed mode in CI.